Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Removed obsoleted field Inspection #117

Merged
merged 2 commits into from
Oct 23, 2023
Merged

🧹 Removed obsoleted field Inspection #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2273825
Removed obsoleted field Inspection
greymistcube Oct 23, 2023
7c389e0
Changelog
greymistcube Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Bencodex/Types/Binary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ public Binary(string text, Encoding encoding)
CommonVariables.Separator.LongLength +
ByteArray.Length;

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

public static explicit operator Binary(ImmutableArray<byte> bytes) =>
new Binary(bytes);

Expand Down
4 changes: 0 additions & 4 deletions Bencodex/Types/Boolean.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ public Boolean(bool value)
[Pure]
public long EncodingLength => 1L;

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

public static implicit operator bool(Boolean boolean)
{
return boolean.Value;
Expand Down
4 changes: 0 additions & 4 deletions Bencodex/Types/Dictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,10 +940,6 @@ public long EncodingLength
internal set => _encodingLength = value;
}

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

/// <inheritdoc cref="IReadOnlyDictionary{TKey,TValue}.this[TKey]"/>
public IValue this[IKey key] => _dict[key];

Expand Down
7 changes: 0 additions & 7 deletions Bencodex/Types/IValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ public interface IValue : IEquatable<IValue>
[Pure]
long EncodingLength { get; }

/// <summary>A human-readable representation for debugging.</summary>
/// <returns>A human-readable representation.</returns>
/// <remarks>This property is deprecated. Use <see cref="Inspect(bool)"/>
/// method instead.</remarks>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
string Inspection { get; }

/// <summary>
/// Gets a human-readable representation for debugging.
/// <para>Unloaded values may be omitted.</para>
Expand Down
4 changes: 0 additions & 4 deletions Bencodex/Types/Integer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ public Integer(string value, IFormatProvider? provider = null)
public long EncodingLength =>
2L + CountDecimalDigits();

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

public static implicit operator BigInteger(Integer i)
{
return i.Value;
Expand Down
4 changes: 0 additions & 4 deletions Bencodex/Types/List.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,6 @@ public long EncodingLength
private set => _encodingLength = value;
}

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

/// <inheritdoc cref="IReadOnlyCollection{T}.Count"/>
public int Count => _values.Length;

Expand Down
4 changes: 0 additions & 4 deletions Bencodex/Types/Null.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ namespace Bencodex.Types
[Pure]
public long EncodingLength => 1L;

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

public override int GetHashCode() => 0;

int IComparable.CompareTo(object obj) => obj is Null ? 0 : -1;
Expand Down
4 changes: 0 additions & 4 deletions Bencodex/Types/Text.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ public Text(string value)
CommonVariables.Separator.LongLength +
Utf8Length;

/// <inheritdoc cref="IValue.Inspection"/>
[Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
public string Inspection => Inspect(true);

[Pure]
internal int Utf8Length =>
_utf8Length is { } l ? l : (
Expand Down
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ Version 0.16.0

To be released.

- Removed `IValue.Inspection` property. [[#117]]

[#117]: https://github.com/planetarium/bencodex.net/pull/117


Version 0.15.0
--------------
Expand Down
Loading