Fix strfry x-forwarded-for ip by using network_mode: host #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the events service queue, I noticed that events pushed from it were being rejected due to rate limits. The issue occurred because strfry was only seeing Traefik’s internal IP instead of the actual client IP. To resolve this, I added network_mode: "host" to the Traefik service configuration. With this change, strfry now correctly sees the real client IP, and events are no longer rejected.
Caveats:
I acknowledge that using network_mode: "host" is a more open configuration, but given the nature of our relay, which is designed to be highly exposed, this should not introduce significant risks. I also explored alternatives to expose the X-Forwarded-For header without enabling host networking but could not find a suitable solution.