Unhardcode relay secret #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mplorentz this is already working and deployed for both relays, but an incoming change into the relay frontend is pending. The test key is exposed in the relay code but we don't care because now it's useless, except for those groups where it's also the admin key |
mplorentz
previously approved these changes
Feb 6, 2025
inventories/groups_relay/host_vars/communities.nos.social/main.yml
Outdated
Show resolved
Hide resolved
mplorentz
previously approved these changes
Feb 14, 2025
dcadenas
dismissed
mplorentz’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new secrets to the ansible vaults for full privileges on relay admin tasks for communities.nos.social and communities2.nos.social. I also added new settings to the yml