-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing p tag #41
Conversation
I'm not sure if this could break the app so better to have a proper review |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! But you got me to check the iOS code and it actually does have a bug where any report with a p tag will be treated like a report of the author, not the note. I will file a ticket, and I already have it fixed in the code. I guess we can talk with Linda about whether we should wait to deploy this change until it's fixed on iOS or not.
Here is the iOS bug ticket if you want to watch it: |
Cool, I will wait for @setch-l green light to merge |
@dcadenas - You can merge this. I moved the other bug to the top of the Delivery Backlog |
I extracted the change for the
p
tag from #40 so we can merge independently