Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing p tag #41

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Add missing p tag #41

merged 2 commits into from
Apr 4, 2024

Conversation

dcadenas
Copy link
Contributor

@dcadenas dcadenas commented Apr 3, 2024

I extracted the change for the p tag from #40 so we can merge independently

@dcadenas dcadenas requested a review from mplorentz April 3, 2024 13:20
@dcadenas
Copy link
Contributor Author

dcadenas commented Apr 3, 2024

I'm not sure if this could break the app so better to have a proper review

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dcadenas dcadenas requested review from mplorentz and removed request for mplorentz April 4, 2024 15:53
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! But you got me to check the iOS code and it actually does have a bug where any report with a p tag will be treated like a report of the author, not the note. I will file a ticket, and I already have it fixed in the code. I guess we can talk with Linda about whether we should wait to deploy this change until it's fixed on iOS or not.

@mplorentz
Copy link
Member

Here is the iOS bug ticket if you want to watch it:
planetary-social/nos#997

@dcadenas
Copy link
Contributor Author

dcadenas commented Apr 4, 2024

Cool, I will wait for @setch-l green light to merge

@setch-l
Copy link

setch-l commented Apr 4, 2024

@dcadenas - You can merge this. I moved the other bug to the top of the Delivery Backlog

@dcadenas dcadenas merged commit dd27d49 into main Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants