-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content flag send selection category #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get a chance to do a really thorough review yet but overall this is looking very good! I had one very minor request below. Other than that I think we could merge this (although I see it depends on another PR which still has a requested change).
…ent-flag-send-to-selection
All requested changes in the previous branch has been made, I didn't want to tag @joshuatbrown today for a final PR since he is OOO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nos/Models/FlagOption.swift
Outdated
@@ -3,34 +3,55 @@ import Foundation | |||
/// A model representing a flagging option used in content moderation. | |||
/// - `title`: The title of the flagging option. | |||
/// - `description`: An optional description that provides more detail about the flagging option. | |||
/// - `info`: An optional message that will be displayed when the user has selected a particular flag. | |||
/// - `id`: A unique identifier for the flagging option, based on the `title`. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting we remove the extra line here since we try to keep our doc comments right above the thing they're documenting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty
@joshuatbrown, figma has a little extra space at the bottom for point 2. Thanks for catching 1, I have added a fix for it. https://www.figma.com/design/s0qf4VmyQygydP8MIQazZc/Nos?node-id=8505-13706&t=6hmFfcSIzeUDOzt4-4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pelumy you're absolutely right -- there is some extra space at the bottom in Figma. Good catch. This is looking perfect!
Issues covered
#1499
Part 2 of #1489
Description
This PR includes the functionality to choose how to flag a content in the new moderation flow.
How to test
Flag this content
option.Screenshots/Video
Screen.Recording.2024-09-19.at.2.46.08.PM.mov