Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a build error in staging builds #1525

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix a build error in staging builds #1525

merged 2 commits into from
Sep 20, 2024

Conversation

joshuatbrown
Copy link
Contributor

@joshuatbrown joshuatbrown commented Sep 19, 2024 •
edited
Loading

Issues covered

None

Description

Staging builds started failing about a week ago. This fixes them.

How to test

  1. Select the NosStaging scheme
  2. Build

Before this PR, it fails. After, it builds.

Notes

The error, which you can find in the GitHub Action as well as the build logs if you build locally, is this:

.../SettingsView.swift:285:55: Function declares an opaque return type, but has no return statements in its body from which to infer an underlying type

@joshuatbrown joshuatbrown requested a review from pelumy September 19, 2024 20:11
mplorentz
mplorentz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh!

@joshuatbrown joshuatbrown added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 3d3fb8d Sep 20, 2024
4 checks passed
@joshuatbrown joshuatbrown deleted the fix-build branch September 20, 2024 13:35
@pelumy
Copy link
Contributor

pelumy commented Sep 20, 2024 •
edited
Loading

Thanks for fixing this @joshuatbrown 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplorentz mplorentz mplorentz approved these changes

@martindsq martindsq Awaiting requested review from martindsq martindsq is a code owner

@pelumy pelumy Awaiting requested review from pelumy pelumy is a code owner

Assignees
No one assigned
Labels
Skip-Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuatbrown @pelumy @mplorentz