Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust note card header UI #1692

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Adjust note card header UI #1692

merged 9 commits into from
Nov 27, 2024

Conversation

pelumy
Copy link
Contributor

@pelumy pelumy commented Nov 18, 2024

Issues covered

#23

Description

This PR adjusts the UI of the note card header to make it more readable. It removes the "posted" and "replied" texts. It also adjusts the spacing and makes the posted date show the month in short form. I also added same padding to the note footer because it was looking off after adjusting that of the header.

How to test

  1. Search for a note.
  2. Please compare it to this figma UI.

Screenshots/Video

Before After
Before After

@joshuatbrown
Copy link
Contributor

👀

Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

# Conflicts:
#	Nos/Assets/Localization/Reply.xcstrings
@joshuatbrown joshuatbrown added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 0dfd5f3 Nov 27, 2024
4 checks passed
@joshuatbrown joshuatbrown deleted the adjust-note-card-header-UI branch November 27, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants