Lists UI

[bryanmontz]

Merges lists UI feature branch.

[mplorentz]

👀

[mplorentz]

I reviewed most of this but I didn't have time to look at the View code. I had a lot of trouble testing it because Listr wasn't working and when I did finally get some lists going Nos wouldn't display any of them. I started putting breakpoints in to see what was happening and then it started working 🤦‍♂️ I can't reproduce it anymore. My hope right now is that my local Core Data got into a weird state from testing this and Josh's list work before it was finished.

Leaving some minor comments below. Overall I'm not against merging this if it's working for others.

[mplorentz]

I think we should bump the "new notes available" toast down by the height of the new feed selector bar.

[mplorentz]

I ran across a bug with displaying a list on launch. My steps to reproduce:

1. Select a list
2. Force quit the app
3. Relaunch
   Expected: my list is still selected and content from it is displayed
   Actual: my list is still selected but a note from someone not on the list is displayed. If I scroll down and back up it disappears.

(this video starts at step 3)

ScreenRecording.mp4

Github is failing to render the video for me, but I was able to right click it and "save as" so hopefully you can too.

[bryanmontz]

@mplorentz I think/hope I fixed the issue you mentioned above with a hacky delay. I want to return to this after we ship.

[mplorentz]

Unfortunately the hack didn't fix the feed when launching with something other than "Following" selected. I'm going to comment out the code that loads the last selected feed on app launch, because that will feel less broken. We can get it fixed up in a future PR.

Other than that, this is working great for me!