Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: adding/removing relays not reflected on feed filter #119 #1723

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

bryanmontz
Copy link
Contributor

Issues covered

https://github.com/verse-pbc/issues/issues/119

Description

Fixes the issue where changes to the user's relays are not immediately reflected on the feed filter picker view.

How to test

  1. Navigate to the Feed tab. Observe the state of the relays in the feed filter picker at the top.
  2. Navigate to the side menu
  3. Open the Relays view
  4. Add or remove a relay
  5. Navigate back to the Feed tab.
    At this point the relays in the filter picker should have been updated already.

Screenshots/Video

In both videos below, the user is trying add the "nos.lol" relay.

Before After
before after

@joshuatbrown
Copy link
Contributor

👀

Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works perfectly!

@joshuatbrown joshuatbrown added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 3dcea55 Jan 6, 2025
4 checks passed
@joshuatbrown joshuatbrown deleted the bdm/119-feed-relays-editing branch January 6, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants