Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added view for editing a list's title and description #134 #1729

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

bryanmontz
Copy link
Contributor

@bryanmontz bryanmontz commented Jan 11, 2025

Issues covered

https://github.com/verse-pbc/issues/issues/134

Description

Adds a view for editing the title and description of an AuthorList. This view can be used for simply editing those properties of an existing list or as the first step in a list-creation wizard (step 2 coming in a separate PR).

Note: There were also some intentional, very minor changes to the layout of the NosForm/NosSection components to match the lists design. This will make the same change everywhere they are used, such as on the edit profile view (see before/after below).

How to test

Creating (only step 1 for this PR):

  1. Open the side menu
  2. Tap "Your Lists"
  3. Tap "New" button at top right
  4. Enter a name and description for the list.
    Note: The "Next" button does nothing for now.

Updating:

  1. Open the side menu
  2. Tap "Your Lists"
  3. Tap the ellipsis button on one of your lists
  4. Edit the name and description
  5. Tap the "Save" button at top right
    Your changes are saved and the view is dismissed.

Screenshots/Video

Creating:
creating

Updating:
updating

Minor layout changes to NosForm/NosSection:

Before After
Bob_s_Phone Bob_s_Phone

@pelumy
Copy link
Contributor

pelumy commented Jan 13, 2025

👀

Copy link
Contributor

@pelumy pelumy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! 🎉

@bryanmontz bryanmontz merged commit ea2e46c into feature/edit-lists-ui Jan 14, 2025
4 checks passed
@bryanmontz bryanmontz deleted the bdm/134-edit-list-view branch January 14, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants