Add breadcrumbs to Sentry for all analytics events #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatbrown
requested review from
mplorentz,
pelumy and
bryanmontz
as code owners
joshuatbrown
commented
Jan 14, 2025
Comment on lines
+315
to
+323
| /// Adds a breadcrumb for the given event name for tracking in our error reporting tool (Sentry). | ||
| /// - Parameter eventName: The event for which to add a breadcrumb. | ||
| private func trackBreadcrumb(_ eventName: String) { | ||
| let crumb = Breadcrumb() | ||
| crumb.level = SentryLevel.info | ||
| crumb.category = "analytics" | ||
| crumb.message = eventName | ||
| SentrySDK.addBreadcrumb(crumb) | ||
| } |
There was a problem hiding this comment.
This should be in CrashReporting, and perhaps Analytics can call it. Still not sure if Analytics should depend on CrashReporting but I am sure this code goes in CrashReporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
https://github.com/verse-pbc/issues/issues/125
Description
Adds breadcrumbs to Sentry whenever an analytics event happens.
How to test
I'm really not sure. The app should keep working as it was before. But do these breadcrumbs show up in Sentry? I'm not sure how to find out. I think it would require us to create a crash or error since breadcrumbs only show up in those in Sentry; I don't think there's a separate view for them. But I could be wrong.
Screenshots/Video
None