Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified ISISGrammar to deal with #-comments and pvl_validate update #74

Merged
merged 6 commits into from
Dec 13, 2020
Merged

Modified ISISGrammar to deal with #-comments and pvl_validate update #74

merged 6 commits into from
Dec 13, 2020

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Dec 5, 2020

Description

  • Modified pvl_validate to more robustly deal with errors, and also provide more error-reporting via -v and -vv.
  • Modified ISISGrammar so that it can parse comments that begin with an octothorpe (#).
  • Altered documentation in grammar.py that was incorrectly indicating that there were parameters that could be passed on object initiation that would alter how those objects behaved.

Related Issue

Would close #73

How Has This Been Tested?

  • make lint
  • make docs
  • make test-all

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the pvl project uses.

@rbeyer
test(grammar): Added a test file and a test that shows that ISISGramm…
e0f73db 
…ar doesn't parse octothorpe (#) comments.

Also ensured that OmniParser is tested against all files that
ISISGrammar is tested against.
@rbeyer
feat(pvl_validate): Now better handles errors, and provides additiona…
ae79abc 
…l reporting information via -v and -vv arguments.
@rbeyer
docs(grammar): Documentation was incorrectly indicating that paramete…
27c23fe 
…rs could be passed to grammar objects on instantiation.
@rbeyer
feat(ISISGrammar): Added the ability to deal with octothorpe (#) comm…
939e597 
…ents.
@rbeyer
docs: fixed some lint issues
7c8f248
@rbeyer
docs: Update version number
7bd8a78
@rbeyer rbeyer merged commit b4662b3 into planetarypy:main Dec 13, 2020
@rbeyer rbeyer deleted the grammar-73 branch December 13, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAnnex AndrewAnnex Awaiting requested review from AndrewAnnex

@michaelaye michaelaye Awaiting requested review from michaelaye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pvl.grammar objects have incorrect documentation, and ISISGrammar needs to handle #-comments
1 participant
@rbeyer