-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
363 enable light/dark mode with a preference for user system settings #364
363 enable light/dark mode with a preference for user system settings #364
Conversation
Hello, and thank you for contributing to the Upsun demo project! Setting up testsUntil all tests pass, a pull request will not be merged. Build tests for combinations of Python and Node.js will happen automatically, and must pass in order to merge. Failing testsIf your PR is failing, see the Running tests section of the README for troubleshooting details. Reviewing these changes locally:
|
Closing in favor of #365 to support |
Pull request was closed
How to test locally
Start the demo app locally
npm run start:backend
REACT_APP_ENABLE_DESIGN_DEBUG=true npm run start:frontend
ENABLE_DESIGN_DEBUG
variable enables you to emulate each step of the demo appTest this MR
This MR adds light/dark mode functionality to the demo app to support developers who may have a preference or struggle to read in one mode or the others. By default, the mode will default to the system preference provided by the operating system of the user.
Once the user overrides with their preference, it is stored in a local storage key named
theme
.Testing system mode
Testing preferred setting