#213 Add WSClientConfig support to the Akka Http backend #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2m
commented
Jan 23, 2018
| () -> req, | ||
| (ua) -> req.addHeader(UserAgent.create( | ||
| // FIXME JAVA API expose ProductVersion.parseMultiple in Java API | ||
| scala.collection.JavaConverters.seqAsJavaList(ProductVersion.parseMultiple(ua)).toArray(new ProductVersion[0]) |
There was a problem hiding this comment.
This will be cleaned up a bit after akka/akka-http#1807
2m
force-pushed
the
wip-akka-http-ws-config-2m
branch
from
5c60576
to
47565c8
Compare
ktoso
reviewed
Jan 24, 2018
| @@ -83,7 +84,7 @@ trait AkkaServerProvider extends BeforeAfterAll { | |||
| new HttpsConnectionContext(context) | |||
| } | |||
|
|
|||
| def clientHttpsContext() = { | |||
| def clientHttpsContext(akkaSslConfig: Option[AkkaSSLConfig] = None): HttpsConnectionContext = { | |||
There was a problem hiding this comment.
prefer overloads than default values? (bin compat)
There was a problem hiding this comment.
This is in testing machinery. So does not really matter.
ktoso
reviewed
Jan 24, 2018
| * | ||
| * @return a WSClientConfig configuration object. | ||
| */ | ||
| def forConfig(): WSClientConfig = |
There was a problem hiding this comment.
I agree, but this is how it was done while creating AHC config. Therefore I decided to keep the consistency.
ktoso
reviewed
Jan 24, 2018
| case HttpEncodings.deflate ⇒ | ||
| Deflate | ||
| case _ ⇒ | ||
| NoCoding |
There was a problem hiding this comment.
should this log that unknown encoding?
ktoso
reviewed
Jan 24, 2018
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
hehe so weird / cool to see akka http routes in here, great :)
ktoso
reviewed
Jan 24, 2018
ktoso
approved these changes
Jan 24, 2018
|
Closing the akka-http backend related tickets for now. These will be handled in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds WSClientConfig support for the Akka Http backend. The only two supported config parameters are
userAgentandcompressionEnabled. New tests are added that tests these parameters in AHC and Akka Http backends for both Java and Scala APIs.Other config parameters need corresponding features from #207.
This PR builds on top of #208 and therefore should be rebased and retargeted to master after #208 is merged.
Fixes #213