Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: use fn.FuncList for closing functions #1142

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Nov 20, 2023

also add context for each service to terminate all gorutines depends on service ctx

also add context for each service to terminate all gorutines
depends on service ctx
@jkralik jkralik force-pushed the jkralik/fix/clean-test-resources branch 3 times, most recently from c23c9d7 to b255b8d Compare November 21, 2023 14:07
@jkralik jkralik force-pushed the jkralik/fix/clean-test-resources branch from b255b8d to 2615bf8 Compare November 22, 2023 08:01
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.4% 90.4% Coverage
6.5% 6.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jkralik jkralik marked this pull request as ready for review November 22, 2023 10:27
@jkralik jkralik merged commit 7e47139 into main Nov 22, 2023
26 of 27 checks passed
@jkralik jkralik deleted the jkralik/fix/clean-test-resources branch November 22, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants