Fixes Unvalidated Email Succeeding to group addition

Products/CMFPlone/controlpanel/browser/usergroups_groupdetails.py

@@ -2,13 +2,23 @@
 from plone.base import PloneMessageFactory as _
 from plone.protect import CheckAuthenticator
 from Products.CMFCore.utils import getToolByName
-from Products.CMFPlone.controlpanel.browser.usergroups import (
-    UsersGroupsControlPanelView,
-)
+from Products.CMFPlone.controlpanel.browser.usergroups import UsersGroupsControlPanelView
+from Products.CMFPlone.PloneTool import PloneTool
 from Products.statusmessages.interfaces import IStatusMessage
 
-
 class GroupDetailsControlPanel(UsersGroupsControlPanelView):
+    def extract_invalid_emails(self, emails):
+        """Validate a list of email addresses."""
+        if isinstance(emails, str):
+            emails = [e.strip() for e in emails.split('\n') if e.strip()]
+
+        invalid_emails = []
+        for email in emails:
+            if not PloneTool.validateEmailAddresses(email):
+                invalid_emails.append(email)
+
+        return invalid_emails
+
     def get_group_property(self, prop_id):
         try:
             return self.group.getProperty(prop_id, None)
@@ -40,6 +50,19 @@ def __call__(self):
             title = self.request.form.get("title", None)
             description = self.request.form.get("description", None)
             addname = self.request.form.get("addname", None)
+
+            # Get email field(s) from the form
+            emails = self.request.form.get("email", "")
+
+            # Validate emails before proceeding
+            invalid_emails = self.validate_group_emails(emails)
+            if invalid_emails:
+                msg = _(
+                    "Invalid email address(es): ${emails}. Please correct them before proceeding.",
+                    mapping={"emails": ", ".join(invalid_emails)},
+                )
+                IStatusMessage(self.request).add(msg, "error")
+                return self.index()
 
             if addname:
                 if not self.regtool.isMemberIdAllowed(addname):
@@ -84,11 +107,20 @@ def __call__(self):
 
             processed = {}
             for id, property in self.gdtool.propertyItems():
-                processed[id] = self.request.get(id, None)
+                value = self.request.get(id, None)
+                # Additional validation for email properties
+                if id.lower().endswith('email') and value:
+                    invalid_emails = self.validate_group_emails(value)
+                    if invalid_emails:
+                        msg = _(
+                            "Invalid email address(es) in ${field}: ${emails}",
+                            mapping={"field": id, "emails": ", ".join(invalid_emails)},
+                        )
+                        IStatusMessage(self.request).add(msg, "error")
+                        return self.index()
+                processed[id] = value
 
             if self.group:
-                # for what reason ever, the very first group created does not
-                # exist
                 self.group.setGroupProperties(processed)
 
             IStatusMessage(self.request).add(msg, type=self.group and "info" or "error")
@@ -99,4 +131,4 @@ def __call__(self):
                 self.request.response.redirect(target_url)
                 return ""
 
-        return self.index()
+        return self.index()

news/933.bugfix

@@ -0,0 +1 @@
+fixes unvalidated email field succeeding in group addition @rohnsha0