-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pep 420 native namespace #34
Conversation
@icemac thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Maybe we need the other packages in the five namespace also to be checkout out here to get Jenkins green. Who could do this for me – I do not want to dig into how it is done in Plone, sorry. |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we do need find_namespace_packages
, because this does not have a src
directory.
It goes surprisingly well, but I don't trust it.
We could indeed try the Jenkins tests with those other five
packages included`.
Or we wait until I have fixed collective.recipe.omelette
, which is really the one who messes up the tests here.
I update to use I think it is better to wait for the fix in |
This can be merged, together with your other PRs for |
I released the packages in the |
Now all the repos in the |
I have released |
No description provided.