Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep 420 native namespace #34

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Pep 420 native namespace #34

merged 4 commits into from
Feb 18, 2025

Conversation

icemac
Copy link
Contributor

@icemac icemac commented Feb 12, 2025

No description provided.

@icemac icemac self-assigned this Feb 12, 2025
@mister-roboto
Copy link

@icemac thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@icemac
Copy link
Contributor Author

icemac commented Feb 12, 2025

@jenkins-plone-org please run jobs

@icemac
Copy link
Contributor Author

icemac commented Feb 12, 2025

Maybe we need the other packages in the five namespace also to be checkout out here to get Jenkins green. Who could do this for me – I do not want to dig into how it is done in Plone, sorry.

@icemac
Copy link
Contributor Author

icemac commented Feb 12, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we do need find_namespace_packages, because this does not have a src directory.

It goes surprisingly well, but I don't trust it.

We could indeed try the Jenkins tests with those other five packages included`.

Or we wait until I have fixed collective.recipe.omelette, which is really the one who messes up the tests here.

@icemac
Copy link
Contributor Author

icemac commented Feb 13, 2025

I update to use find_namespace_packages again.

I think it is better to wait for the fix in collective.recipe.omelette.

@mauritsvanrees
Copy link
Member

This can be merged, together with your other PRs for five packages. But we can't use it in Plone yet until we have releases for all of them. Or we use a checkout for all. Otherwise Buildout fails to give us working scripts. See buildout/buildout#676

@icemac
Copy link
Contributor Author

icemac commented Feb 15, 2025

I released the packages in the five namespace which I was allowed to.

@icemac
Copy link
Contributor Author

icemac commented Feb 15, 2025

Now all the repos in the five namespace in zopefoundation are released with PEP-420 namespaces.

@mauritsvanrees mauritsvanrees merged commit 79e2a88 into master Feb 18, 2025
10 of 14 checks passed
@mauritsvanrees mauritsvanrees deleted the pep-420-native-namespace branch February 18, 2025 13:02
@mauritsvanrees
Copy link
Member

mauritsvanrees commented Feb 18, 2025

I have released five.intid 3.0.0 to PyPI. Plone coredev 6.2 is using all the latest "five" releases with native namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants