Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3953 move plone app workflow to plone app layout #390

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented Feb 13, 2025

No description provided.

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

news entry missing, otherwise LGTM

@MrTango
Copy link
Contributor Author

MrTango commented Feb 13, 2025

i added a separate PR #391 for the browserlayer

@MrTango MrTango force-pushed the 3953-move-plone-app-workflow-to-plone-app-layout branch from c7d575b to c4fa40c Compare February 13, 2025 14:43
Comment on lines +3 to +4
<layer interface="plone.app.layout.interfaces.IPloneAppLayoutLayer"
name="plone.app.layout"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<layer interface="plone.app.layout.interfaces.IPloneAppLayoutLayer"
name="plone.app.layout"
<layer name="plone.app.layout"

>

<include
package="plone.app.workflow"
file="permissions.zcml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should all the package be included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants