Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The templates do not rely anymore on the toLocalizedTime skin script #397

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Mar 19, 2025

They use the @@plone.toLocalizedTime helper instead.

Closes #396

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Mar 19, 2025

@jenkins-plone-org please run jobs

They use the @@plone.toLocalizedTime helper instead.

Fixes #396
@ale-rt ale-rt force-pushed the ale/toLocalizedTime branch from c0379ca to ac79ad4 Compare March 19, 2025 10:17
@ale-rt
Copy link
Member Author

ale-rt commented Mar 19, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@gforcada gforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks to improve the deprecation notice to point what to use instead ❤️

@ale-rt ale-rt merged commit 2082c5d into master Mar 19, 2025
12 checks passed
@ale-rt ale-rt deleted the ale/toLocalizedTime branch March 19, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not rely on the toLocalizedTime skin script
3 participants