Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email validation, add tests #40

Merged
merged 6 commits into from
Feb 19, 2025
+202 −18
Merged

Fix email validation, add tests #40

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
553e047
Refactor the jsonfield doctest to a simpler unit test.
mauritsvanrees Feb 18, 2025
78ce5be
Add basic tests for the email field.
mauritsvanrees Feb 18, 2025
eb8db65
Fix email validation.
mauritsvanrees Feb 18, 2025
0818901
Update classifiers.
mauritsvanrees Feb 18, 2025
32c1086
fix typo in comment
mauritsvanrees Feb 18, 2025
9627aad
Better check of domain part.
mauritsvanrees Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo in comment
@mauritsvanrees
mauritsvanrees committed Feb 18, 2025
commit 32c1086a581dcc892e5c9cc20b5701d99139513e
2 changes: 1 addition & 1 deletion plone/schema/email.py
View file
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ def _isemail(value):
if len(domain) < 3:
return False

# Tthe maximum length of an email address that can be handled by SMTP
# The maximum length of an email address that can be handled by SMTP
# is 254 characters.
if len(value) > 254:
return False