-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access by column #1002
Add access by column #1002
Conversation
@laowantong Hey is there a related issue? Please mention the issue number also |
No existing issue. I have just tried to add a feature which I felt was missing for my usage. Not sure why some checks fail. Feel free to close this PR is the procedure is not OK or you think the feature is useless. |
Sure will have a look. There are lint issues in the changes. Please refer to contributing guidelines |
Sorry for spamming you with my failed attempts to make the checks pass. There are still lint issues, although pkgfmt succeeds on my machine:
|
This reverts commit fc2cd55.
Just reformat the files I have actually touched, since the other ones seem to block the PR
The lints are passing but the testcase |
Too much friction for me, sorry. I cannot run the tests on my machine. There are multiple failures everywhere. I give up. You can close this PR. Thanks. |
Describe your changes
The proposed method
ResultSet.column()
iterates on a column given by name.jupysql/src/sql/run/resultset.py
Lines 249 to 256 in 17ab97c
Additions:
column(name)
inresultset.py
(above);test_resultset_column(result_set)
intest_resultset.py
with a successful test and a failed test;doc_intro.md
;changelog.md
.Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--1002.org.readthedocs.build/en/1002/