Andrew/372 check paths #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvwilson
added
community
emilykl
reviewed
Aug 14, 2025
emilykl
reviewed
Aug 14, 2025
emilykl
reviewed
Aug 14, 2025
src/py/kaleido/_page_generator.py
Outdated
| force_cdn: (default False) Don't use plotly import, use CDN | ||
| plotly: The url to the plotly.js to use. Defaults to plotly.js | ||
| present in plotly.py, if installed. Otherwise fallback to | ||
| global constant. |
There was a problem hiding this comment.
could you edit this docstring to describe where to find these global constants? to help someone who might be trying to debug
There was a problem hiding this comment.
(not highest priority just trying to think about how to make these docstrings slightly less opaque)
emilykl
requested changes
Aug 14, 2025
emilykl
reviewed
Aug 14, 2025
Co-authored-by: Emily KL <[email protected]>
Co-authored-by: Emily KL <[email protected]>
emilykl
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #372