Make #3351 acceptable only for sync version (async version has self-owned if not config.suppress_callback_exceptions ... block) #3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…self-owned if not config.suppress_callback_exceptions ... block)
gvwilson
added
P1
|
@T4rk1n please have a look |
T4rk1n
reviewed
Jul 4, 2025
| ] | ||
| + layout | ||
| ) | ||
| if _ID_CONTENT not in self.validation_layout: |
There was a problem hiding this comment.
I think this one need to be indented one more level too.
There was a problem hiding this comment.
If you mean another additional indented for checking "if _ID_CONTENT ... " - then as far as I understand, no. Here, only the self.validation_layout property is redefined if necessary. It can also be set in the layout() method/property, and the checking should occur in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3358