Skip to content

Fix box trace with "all" points and line_width=0 doesn't render marker in legend #7162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix box trace with "all" points and line_width=0 doesn't render marker in legend #7162

wants to merge 5 commits into from

Conversation

jnumainville
Copy link

Fixes #7159 with both the box and violin, so now points show up in the legend when fillcolor is transparent, line width is 0, and points/boxpoints is set to "all"

@gvwilson gvwilson requested a review from emilykl September 23, 2024 14:22
@gvwilson gvwilson added community community contribution P3 backlog fix fixes something broken labels Sep 23, 2024
emilykl
emilykl reviewed Sep 26, 2024
View reviewed changes
@archmoj
Copy link
Contributor

archmoj commented Sep 27, 2024

Please download and replace this file in test/image/baselines from https://circleci-tasks-prod.s3.us-east-1.amazonaws.com/forks/storage/artifacts/65346d72-8e7b-46e9-8db2-cbb77f4980f3/858848683/118db48b-9ac5-4117-9be9-2d1cc9db4f31/0/test_images/box_violin_just_pts.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQVFQINEOMDGN4HWB%2F20240927%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240927T124542Z&X-Amz-Expires=60&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEOX%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIG1P7fcEFeRoj1X1GWQJHC8KH2kn2QiJjRkLZx2omZxEAiEAx6iS3m3oSH63p%2FHgXCZs4K%2B8iITmFu4HQFqjF1H%2BZgwqqwIILhADGgwwNDU0NjY4MDY1NTYiDHXpLV0JMZ6QbLziHyqIAr%2B0wS4eepDxGHvZg6%2FiJNtVOjPqUdm2t6eLDoIxb4anQ3w36g9YXVmTGj%2FaqGpYsTEf0TOVsOUgcR9FTno84OU5j4hjuwflz2Q8xxLRZo7s%2F4MA4W5F4sKv6y4BdcMcqjsxNQ9E1YN9C7WwlQQx7E7JRnZWIYfMTmmcS1xsI%2FZQElxskalrgiwqtO5d41LQkXvK2AZcOzi7yKvnDU0tgPgQ69f6nihIpkqwz4%2FifaXtN8ZvORF5YPqsF55CHXPWkXEbVAxRHLGV4Dmo8kKdKufB4dvURbAnlQk2Mzb0u2Eo341SPjFK5p1GPV039SN6tpbt1K3insn%2F8CSUN74zI0s2akXGKOP5QTCs0dq3BjqdASY%2BmK5jTsaLPA6u98ZiqNzkefdULsUyaviWydj7ZmfSSsdtBhlCUu1uie%2B8MxKlG8VRSSjgZlDmjEob%2BBBxmXMnzT%2FlVeaTKf9RY7K5BzO7o3BKuGllY%2FVfRr4ur%2Fm7nwui%2Bw5J7QSh6t2IfJvptnD8URSVaRHUgDFmk%2FRjuDAT0ay2pXjFTKdK7rGbQZsRPmwIEJiwMOLTNBMjXEU%3D&X-Amz-SignedHeaders=host&x-id=GetObject&X-Amz-Signature=3cc13e22a71e5a80de240bc40ed297fbe791ca9250a814d36c039d0a341dde94

@jnumainville
Copy link
Author

That image shows an error for me but I went into circleci and pulled the image I believe

@mofojed mofojed mentioned this pull request Sep 30, 2024
Open
@jnumainville jnumainville mentioned this pull request Oct 1, 2024
Closed
@jnumainville jnumainville requested a review from emilykl October 15, 2024 13:44
@jnumainville
Copy link
Author

I'm not sure why those tests are failing they don't seem to be related? @archmoj @emilykl is there anything else I need to do to get this through? Thanks!

@jnumainville
Copy link
Author

Hello, is there anything I can do to help finish this out? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykl emilykl Awaiting requested review from emilykl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community community contribution fix fixes something broken P3 backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Box trace with boxpoints="all" and line_width=0 doesn't render marker in legend
4 participants
@jnumainville @archmoj @emilykl @gvwilson