-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix typos #7532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix typos #7532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few comments about how to proceed. Unfortunately, a lot of these typos are from dependencies and won't be able to be fixed inside plotly.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change likely altered the result of some test images, which makes sense. You can download the new images from the Artifacts tab in the CircleCI results and save those into the test images folder and commit them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
download the new images from the Artifacts tab in the CircleCI results
I'm unclear on how to do that.
test images folder
I'm unclear on the precise location of the "test images" folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take care of it. It can be confusing if you're unfamiliar with the testing system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you allow edits to the PR by maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow edits from maintainers
I don't see that text and documentation on that invariably refer to a fork's user created branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should show up on the PR as described here. If you aren't able to do that, I'll just create my own PR that incorporates your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't able to do that
"you can modify an existing pull request to let repository maintainers make commits to your branch"
I used the master branch for this pull, maybe that's why the Allow edits... text doesn't appear.
I'll just create my own PR that incorporates your changes.
That seems to be the solution to this circumstance.
virtual-webgl-jasmine - Failed Cannot start Chrome |
Rather than elaborate on how to get the checks to pass, someone else familiar with that could open a successor PR. The |
Closes #7531
using
master
for this pull