fix: command search bar #414
Open
+57
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lui7henrique
requested changes
Feb 25, 2025
| @@ -105,38 +98,36 @@ export const CommandSearchTvSerie = ({ | |||
| </Link> | |||
| </HoverCardTrigger> | |||
|
|
|||
| <HoverCardPortal> | |||
There was a problem hiding this comment.
Remover o HoverCardPortal faz com que o HoverCard fique relativo ao componente "pai" dele, nesse caso, por consequência, se não couber dentro do Command, ficará cortado.
There was a problem hiding this comment.
Sim, era disso que queria falar contigo, pois ele tá quebrando. Pois da forma que estava antes, dá esse erro: Error: HoverCardPortalmust be used withinHoverCard``
There was a problem hiding this comment.
Só quebra em desenvolvimento, da pra deixar passar
There was a problem hiding this comment.
Só que essa quebra tá travando o desenvolvimento dessa outra pr https://github.com/plotwist-app/plotwist/pull/412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review