Comment about empty catch statements

plume-lib · Oct 5, 2024 · 5036387 · 5036387
1 parent 94f22f6
commit 5036387
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/build.gradle b/build.gradle
@@ -23,7 +23,7 @@ repositories {
 }
 
 ext {
-  errorproneVersion = '2.32.0'
+  errorproneVersion = '2.33.0'
   isJava17orHigher = JavaVersion.current() >= JavaVersion.VERSION_17
   isJava21orHigher = JavaVersion.current() >= JavaVersion.VERSION_21
 }

diff --git a/src/test/java/org/plumelib/util/ArraysPlumeTest.java b/src/test/java/org/plumelib/util/ArraysPlumeTest.java
@@ -59,11 +59,13 @@ public void testMinAndMax() {
       ArraysPlume.minAndMax(new int[] {});
       throw new Error("Didn't throw ArrayIndexOutOfBoundsException");
     } catch (ArrayIndexOutOfBoundsException e) {
+      // This is the expected behavior, so do nothing.
     }
     try {
       ArraysPlume.minAndMax(new long[] {});
       throw new Error("Didn't throw ArrayIndexOutOfBoundsException");
     } catch (ArrayIndexOutOfBoundsException e) {
+      // This is the expected behavior, so do nothing.
     }
 
     // public static int elementRange(int[] a)

diff --git a/src/test/java/org/plumelib/util/MathPlumeTest.java b/src/test/java/org/plumelib/util/MathPlumeTest.java
@@ -126,6 +126,7 @@ public void test_pow() {
       MathPlume.pow(3, -3);
       throw new Error("Didn't throw ArithmeticException");
     } catch (ArithmeticException e) {
+      // This is the expected behavior, so do nothing.
     }
   }