Replace methods with accessors

Addresses #349

manual/content/_index.en.md

@@ -28,7 +28,7 @@ WIP
 
 ## Output Encoding
 
-It's recommended to follow a [linear workflow](https://docs.unity3d.com/Manual/LinearRendering-LinearOrGammaWorkflow.html) for color management and `postprocessing` supports this automatically. Simply set `WebGLRenderer.outputEncoding` to `sRGBEncoding` and `postprocessing` will follow suit. Built-in passes automatically encode colors when they render to screen and internal render operations are always performed in linear color space.
+New applications should follow a [linear workflow](https://docs.unity3d.com/Manual/LinearRendering-LinearOrGammaWorkflow.html) for color management and `postprocessing` supports this automatically. Simply set `WebGLRenderer.outputEncoding` to `sRGBEncoding` and `postprocessing` will follow suit. Built-in passes automatically encode colors when they render to screen and internal render operations are always performed in linear color space.
 
 ## Performance
 

src/effects/BloomEffect.js

@@ -69,7 +69,6 @@ export class BloomEffect extends Effect {
 		 * This pass can be disabled to skip luminance filtering.
 		 *
 		 * @type {LuminancePass}
-		 * @deprecated Use getLuminancePass() instead.
 		 */
 
 		this.luminancePass = new LuminancePass({
@@ -84,7 +83,6 @@ export class BloomEffect extends Effect {
 		 * A blur pass.
 		 *
 		 * @type {KawaseBlurPass}
-		 * @deprecated Use getBlurPass() instead.
 		 */
 
 		this.blurPass = new KawaseBlurPass({ resolutionScale, width, height, kernelSize });
@@ -98,7 +96,6 @@ export class BloomEffect extends Effect {
 	 * A texture that contains the intermediate result of this effect.
 	 *
 	 * @type {Texture}
-	 * @deprecated Use getTexture() instead.
 	 */
 
 	get texture() {
@@ -110,6 +107,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * Returns the generated bloom texture.
 	 *
+	 * @deprecated Use texture instead.
 	 * @return {Texture} The texture.
 	 */
 
@@ -123,7 +121,6 @@ export class BloomEffect extends Effect {
 	 * The resolution of this effect.
 	 *
 	 * @type {Resolution}
-	 * @deprecated Use getResolution() instead.
 	 */
 
 	get resolution() {
@@ -135,6 +132,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * Returns the resolution settings.
 	 *
+	 * @deprecated Use resolution instead.
 	 * @return {Resolution} The resolution.
 	 */
 
@@ -147,6 +145,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * Returns the blur pass.
 	 *
+	 * @deprecated Use blurPass instead.
 	 * @return {KawaseBlurPass} The blur pass.
 	 */
 
@@ -159,6 +158,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * Returns the luminance pass.
 	 *
+	 * @deprecated Use luminancePass instead.
 	 * @return {LuminancePass} The luminance pass.
 	 */
 
@@ -172,7 +172,6 @@ export class BloomEffect extends Effect {
 	 * The luminance material.
 	 *
 	 * @type {LuminanceMaterial}
-	 * @deprecated Use getLuminanceMaterial() instead.
 	 */
 
 	get luminanceMaterial() {
@@ -184,6 +183,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * Returns the luminance material.
 	 *
+	 * @deprecated Use luminanceMaterial instead.
 	 * @return {LuminanceMaterial} The material.
 	 */
 
@@ -197,7 +197,7 @@ export class BloomEffect extends Effect {
 	 * The current width of the internal render targets.
 	 *
 	 * @type {Number}
-	 * @deprecated Use getResolution().getWidth() instead.
+	 * @deprecated Use resolution.width instead.
 	 */
 
 	get width() {
@@ -216,7 +216,7 @@ export class BloomEffect extends Effect {
 	 * The current height of the internal render targets.
 	 *
 	 * @type {Number}
-	 * @deprecated Use getResolution().getHeight() instead.
+	 * @deprecated Use resolution.height instead.
 	 */
 
 	get height() {
@@ -254,7 +254,7 @@ export class BloomEffect extends Effect {
 	 * The blur kernel size.
 	 *
 	 * @type {KernelSize}
-	 * @deprecated Use getBlurPass().getKernelSize() instead.
+	 * @deprecated Use blurPass.kernelSize instead.
 	 */
 
 	get kernelSize() {
@@ -271,7 +271,7 @@ export class BloomEffect extends Effect {
 
 	/**
 	 * @type {Number}
-	 * @deprecated Use getLuminanceMaterial().getThreshold() and ...getSmoothingFactor() instead.
+	 * @deprecated Use luminanceMaterial instead.
 	 */
 
 	get distinction() {
@@ -291,7 +291,6 @@ export class BloomEffect extends Effect {
 	 * The bloom intensity.
 	 *
 	 * @type {Number}
-	 * @deprecated Use getIntensity() instead.
 	 */
 
 	get intensity() {
@@ -309,6 +308,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * The bloom intensity.
 	 *
+	 * @deprecated Use intensity instead.
 	 * @return {Number} The intensity.
 	 */
 
@@ -321,6 +321,7 @@ export class BloomEffect extends Effect {
 	/**
 	 * Sets the bloom intensity.
 	 *
+	 * @deprecated Use intensity instead.
 	 * @param {Number} value - The intensity.
 	 */
 
@@ -334,7 +335,7 @@ export class BloomEffect extends Effect {
 	 * Returns the current resolution scale.
 	 *
 	 * @return {Number} The resolution scale.
-	 * @deprecated Use getResolution().setPreferredWidth() or getResolution().setPreferredHeight() instead.
+	 * @deprecated Use resolution instead.
 	 */
 
 	getResolutionScale() {
@@ -347,7 +348,7 @@ export class BloomEffect extends Effect {
 	 * Sets the resolution scale.
 	 *
 	 * @param {Number} scale - The new resolution scale.
-	 * @deprecated Use getResolution().setPreferredWidth() or getResolution().setPreferredHeight() instead.
+	 * @deprecated Use resolution instead.
 	 */
 
 	setResolutionScale(scale) {

src/effects/BrightnessContrastEffect.js

@@ -33,51 +33,91 @@ export class BrightnessContrastEffect extends Effect {
 
 	}
 
+	/**
+	 * The brightness.
+	 *
+	 * @type {Number}
+	 */
+
+	get brightness() {
+
+		return this.uniforms.get("brightness").value;
+
+	}
+
+	set brightness(value) {
+
+		this.uniforms.get("brightness").value = value;
+
+	}
+
 	/**
 	 * Returns the brightness.
 	 *
+	 * @deprecated Use brightness instead.
 	 * @return {Number} The brightness.
 	 */
 
 	getBrightness(value) {
 
-		return this.uniforms.get("brightness").value;
+		return this.brightness;
 
 	}
 
 	/**
 	 * Sets the brightness.
 	 *
+	 * @deprecated Use brightness instead.
 	 * @param {Number} value - The brightness.
 	 */
 
 	setBrightness(value) {
 
-		this.uniforms.get("brightness").value = value;
+		this.brightness = value;
+
+	}
+
+	/**
+	 * The contrast.
+	 *
+	 * @type {Number}
+	 */
+
+	get contrast() {
+
+		return this.uniforms.get("contrast").value;
+
+	}
+
+	set contrast(value) {
+
+		this.uniforms.get("contrast").value = value;
 
 	}
 
 	/**
 	 * Returns the contrast.
 	 *
+	 * @deprecated Use contrast instead.
 	 * @return {Number} The contrast.
 	 */
 
 	getContrast(value) {
 
-		return this.uniforms.get("contrast").value;
+		return this.contrast;
 
 	}
 
 	/**
 	 * Sets the contrast.
 	 *
+	 * @deprecated Use contrast instead.
 	 * @param {Number} value - The contrast.
 	 */
 
 	setContrast(value) {
 
-		this.uniforms.get("contrast").value = value;
+		this.contrast = value;
 
 	}
 

src/effects/ChromaticAberrationEffect.js

@@ -36,7 +36,6 @@ export class ChromaticAberrationEffect extends Effect {
 	 * The color offset.
 	 *
 	 * @type {Vector2}
-	 * @deprecated Use getOffset() instead.
 	 */
 
 	get offset() {
@@ -54,6 +53,7 @@ export class ChromaticAberrationEffect extends Effect {
 	/**
 	 * Returns the color offset vector.
 	 *
+	 * @deprecated Use offset instead.
 	 * @return {Vector2} The offset.
 	 */
 
@@ -66,6 +66,7 @@ export class ChromaticAberrationEffect extends Effect {
 	/**
 	 * Sets the color offset vector.
 	 *
+	 * @deprecated Use offset instead.
 	 * @param {Vector2} value - The offset.
 	 */
 

src/effects/ColorDepthEffect.js

@@ -37,7 +37,28 @@ export class ColorDepthEffect extends Effect {
 		 */
 
 		this.bits = 0;
-		this.setBitDepth(bits);
+		this.bitDepth = bits;
+
+	}
+
+	/**
+	 * The virtual amount of color bits.
+	 *
+	 * Each color channel effectively uses a fourth of the total amount of bits. Alpha remains unaffected.
+	 *
+	 * @type {Number}
+	 */
+
+	get bitDepth() {
+
+		return this.bits;
+
+	}
+
+	set bitDepth(value) {
+
+		this.bits = value;
+		this.uniforms.get("factor").value = Math.pow(2.0, value / 3.0);
 
 	}
 
@@ -49,7 +70,7 @@ export class ColorDepthEffect extends Effect {
 
 	getBitDepth() {
 
-		return this.bits;
+		return this.bitDepth;
 
 	}
 
@@ -61,8 +82,7 @@ export class ColorDepthEffect extends Effect {
 
 	setBitDepth(value) {
 
-		this.bits = value;
-		this.uniforms.get("factor").value = Math.pow(2.0, value / 3.0);
+		this.bitDepth = value;
 
 	}
 

src/effects/DepthEffect.js

@@ -34,7 +34,6 @@ export class DepthEffect extends Effect {
 	 * Indicates whether depth should be inverted.
 	 *
 	 * @type {Boolean}
-	 * @deprecated Use isInverted() instead.
 	 */
 
 	get inverted() {
@@ -66,6 +65,7 @@ export class DepthEffect extends Effect {
 	/**
 	 * Indicates whether the rendered depth is inverted.
 	 *
+	 * @deprecated Use inverted instead.
 	 * @return {Boolean} Whether the rendered depth is inverted.
 	 */
 
@@ -78,6 +78,7 @@ export class DepthEffect extends Effect {
 	/**
 	 * Enables or disables depth inversion.
 	 *
+	 * @deprecated Use inverted instead.
 	 * @param {Boolean} value - Whether depth should be inverted.
 	 */