Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 155 - Log feature ids on db write #160

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

torimcd
Copy link
Collaborator

@torimcd torimcd commented Apr 8, 2024

Github Issue: #155 Log feature ids on db write

Description

Log a few reach_ids and node_ids of a granule during the database write so that automated tests can verify the features written

Overview of work done

Update logging statements in load_data module to write 5 reach_id and node_id values from the granule being ingested

Overview of verification done

No changes to unit tests, only logging statements changed

Overview of integration done

Deployed to SIT, loaded a few granules and verified reach_id and node_ids are being written to the logs during the db write.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

Copy link
Collaborator

@nikki-t nikki-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I was initially thinking it would be good to log all node and reach identifiers but I think that would be too many to be useful. It would make it tough to load and parse the logs so I like that you are adding a few to be used for verification. Plus I think this will be covered by issue #71.

@torimcd
Copy link
Collaborator Author

torimcd commented Apr 9, 2024

Agreed, it completely overwhelms the logs to write them all out. By adding the granuleUR and ingest_time in #150 it will be easy to run a query against the db directly to get all the ids that were written during a given ingest. I think that's a better way to do the full reconciliation for #71 than trying to parse it all out of the logs.

@frankinspace frankinspace merged commit 50c299c into develop Apr 18, 2024
1 check passed
@frankinspace frankinspace deleted the feature/issue-155 branch April 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants