view_id or filters params in Item.item_count #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added one extra API call for the app stream |
| @@ -187,8 +187,11 @@ def find_field_top(field_id, options={:limit => 8}) | |||
| end | |||
|
|
|||
| # @see https://developers.podio.com/doc/items/get-item-count-34819997 | |||
| def item_count(app_id) | |||
| Podio.connection.get("/item/app/#{app_id}/count/").body | |||
| # options are either filters {gender: 1, firstname: "Joe"} or a view {view_id: 123} | |||
There was a problem hiding this comment.
Adding option specifics in the code is discouraged. These may be the options now, but not guaranteed in the future. The API docs should be the source of reference.
|
Please split these 2 commits into individual PRs |
| req.url("/stream/app/#{app_id}/v3/", options) | ||
| }.body | ||
| end | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title ;)