updating version and couple of dependencies #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s.add_dependency('multi_json') | ||
|
|
||
| if RUBY_VERSION < '1.9.3' | ||
| s.add_dependency('i18n', '<= 0.6.11') | ||
| s.add_dependency('activesupport', '~> 3.0') | ||
| s.add_dependency('activemodel', '~> 3.0') | ||
| else | ||
| s.add_dependency('activesupport', '>= 3.0') | ||
| s.add_dependency('activemodel', '>= 3.0') | ||
| s.add_dependency('activesupport', '>= 4.1.11') |
There was a problem hiding this comment.
you will have to update rubysl-test-unit in Gemfile because of minitest gem dependency mismatch.
| s.add_dependency('multi_json') | ||
|
|
||
| if RUBY_VERSION < '1.9.3' | ||
| s.add_dependency('i18n', '<= 0.6.11') | ||
| s.add_dependency('activesupport', '~> 3.0') | ||
| s.add_dependency('activemodel', '~> 3.0') | ||
| else | ||
| s.add_dependency('activesupport', '>= 3.0') | ||
| s.add_dependency('activemodel', '>= 3.0') | ||
| s.add_dependency('activesupport', '>= 4.1.11') |
There was a problem hiding this comment.
Btw why this need came for upgrading the active support version?
since we are using >= which means it will pick the latest version or the version defined in the gemfile.lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.