Turn on Swift 6 language mode. #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one small thing stopping us from turning on Swift 6 mode in this package, and that was our use of a data bytes formatter. It may be OK to just
nonisolated(unsafe)it since the initialization of static variables is thread safe in Swift and since we never mutate the formatter after initialization. But I went ahead and wrapped it in a lock too just in case.Alternatively we could use the new
FormatStylestuff, but then theCustomDumpStringConvertibleconformance will be iOS 15+ (probably not a big deal), but also I don't thinkFormatStyleis implemented in corelibs-foundation.