-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add strict
parameter to pl.concat(how='horizontal')
#20019
Draft
nimit
wants to merge
22
commits into
pola-rs:main
Choose a base branch
from
nimit:strict-concat-19133
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−12
Draft
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6038130
added 'strict' as a keyword argument (default: False) to pl.concat an…
nimit d14049c
bug fix with keyword argument change in pl.concat
nimit ae2a335
Merge branch 'pola-rs:main' into strict-concat-19133
nimit 6a0df66
rust changes
nimit ea847bf
fixed python errors with concat_df_horizontal, concat_lf_horizontal
nimit 8f2883d
fixed exception type in python unit test for strict concatenation of …
nimit 21d110a
build: Bump `chrono-tz` to `0.10` (#20094)
stinodego d85fc9c
chore(rust): Update AWS doc dependencies (#20095)
stinodego f00e6fd
docs(rust): Fix inconsistency between code and comment (#20070)
YichiZhang0613 a413c4a
fix: Only slice after sort when slice is smaller than frame length (#…
mcrumiller 5a8cd16
fix: Return null instead of 0. for rolling_std when window contains a…
MarcoGorelli 755ee47
build: Bump `atoi_simd` to version `0.16` (#20098)
stinodego af4d5a5
build: Bump `thiserror` to version `2` (#20097)
stinodego 06b2ab6
build(rust): Fix path to `polars-dylib` crate in workspace (#20103)
stinodego 511c219
build: Bump `fs4` to version `0.12` (#20101)
stinodego b276485
build: Bump `object_store` to version `0.11` (#20102)
stinodego bc3d320
build: Bump `memmap2` to version `0.9` (#20105)
stinodego 8f72e20
refactor(rust): Replace custom `PushNode` trait with `Extend` (#20107)
nameexhaustion 527af9c
build: Upgrade `sqlparser-rs` from version 0.49 to 0.52 (#20110)
alexander-beedie 0d4029a
fixed LazyFrame test, Python & Rust documentation changes regarding a…
nimit 90e65e8
Merge branch 'pola-rs:main' into strict-concat-19133
nimit 6078964
doc fix, removed unnecessary generic
nimit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this should be implemented on the rust side is that this
collect
here could trigger a massive computation if the query plan is complex, which then gets tossed. The check should be performed when the concatenation operation is actually applied.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. When I initially thought about it, I failed to take into account how I would compare the number of rows on Lazyframes.