-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Model Competitions - Competition Model Services #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Model Competitions - Competition Model Services #279
Conversation
return self | ||
|
||
@abc.abstractmethod | ||
def submit_entry(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only new change in CompetitionSpecification
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @roselynh100! I've left a few small comments but overall, it is very well done 🚀
Let me know if you have any questions about them.
polaris/hub/client.py
Outdated
@@ -979,3 +1019,6 @@ def upload_model( | |||
progress.log( | |||
f"[green]Your model has been successfully uploaded to the Hub. View it here: {model_url}" | |||
) | |||
|
|||
# We need this artifact_id when uploading a new model as a competition submission | |||
return Model(**inserted_model).artifact_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice call on instantiating this here instead of just pulling the returned artifact ID from the json. Either would work, but this feels safer with the Pydantic.
Changelogs
CompetitionSpecification
into an abstract class, which throws an error if instantiated → must usePredictionBasedCompetition
orModelBasedCompetition
insteadsubmit_entry
differently (also, users can callcompetition.submit_predictions
instead)CompetitionSpecification
instances withPredictionBasedCompetition
(mostly in tests)submit_competition_model
allows users to submit a model to a competitionsubmit_to_competition.ipynb
tutorial with instructions for submitting to a model-based competitionChecklist:
feature
,fix
,chore
,documentation
ortest
(or ask a maintainer to do it for you).discussion related to that PR