Skip to content

chore: Replace Union with | in type annotations #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2025
Merged

chore: Replace Union with | in type annotations #281

merged 6 commits into from
Apr 8, 2025

Conversation

roselynh100
Copy link
Contributor

@roselynh100 roselynh100 commented Apr 8, 2025 •
edited
Loading

Changelogs

  • Replaced all usage of typing Union with |
  • Removed deprecated typing imports: List, Dict, Tuple

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

@roselynh100 roselynh100 linked an issue Apr 8, 2025 that may be closed by this pull request
Replace the use of Union with | when defining type annotations #179
Closed
@roselynh100 roselynh100 marked this pull request as ready for review April 8, 2025 14:34
@roselynh100 roselynh100 requested a review from cwognum as a code owner April 8, 2025 14:34
@roselynh100 roselynh100 self-assigned this Apr 8, 2025
mercuryseries
mercuryseries approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@mercuryseries mercuryseries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @roselynh100!

@roselynh100
Copy link
Contributor Author

@mercuryseries I didn't realize some typing imports were deprecated! Just removed all occurrences of those too, thanks :]

@roselynh100 roselynh100 merged commit 92bb0bf into main Apr 8, 2025
19 checks passed
@roselynh100 roselynh100 deleted the chore/replace-union branch April 8, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mercuryseries mercuryseries mercuryseries approved these changes

@cwognum cwognum Awaiting requested review from cwognum cwognum is a code owner

@jstlaurent jstlaurent Awaiting requested review from jstlaurent

@Andrewq11 Andrewq11 Awaiting requested review from Andrewq11

Assignees

@roselynh100 roselynh100

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the use of Union with | when defining type annotations
2 participants
@roselynh100 @mercuryseries