Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Forms #5

wants to merge 2 commits into from

Conversation

renstah
Copy link
Contributor

@renstah renstah commented Jan 20, 2017

No description provided.


* Author: `Lorenzo Wallerlei, [email protected]`
* Date: `19-01-2017`
* Repository name: `Form`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be more specific. Please have a look at #1 for example.


## Requirements

- All the inputs within the form should contain a tab index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Words like MUST,SHOULD,COULD - MUST be in capitals. to make clear that these are part of the MoSCoW list


## Requirements

- All the inputs within the form should contain a tab index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messing with the tab index can be dangerous, you will have to take care that this is not messing up your expected flow through the fields.


## Existing implementations

[https://www.tax.service.gov.uk/gg/sign-in?continue=%2Faccount&origin=unknown]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to show the login form at this page or is there an url behind the login?


What it does good.
- Form fields are described by labels.
- Flow of the tab indexes is natural.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The login form at this URL does not have tabindex attributes set. The flow is logical because by itself already. Just saying :)


### How to use the component with a keyboard only

This MUST be entirely usable with only the tab key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you submit it with a tab key? You need to clarify this sentence.You probably mean to say that it should be usuable with the keyboard.

@waltertamboer
Copy link
Contributor

Am I understanding this correctly that this proposal only describes forms on an abstract level? What about form input elements, select boxes and textarea's?

@waltertamboer waltertamboer changed the title proposal for the form Form Jan 27, 2017
@waltertamboer waltertamboer changed the title Form Forms Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants