Updated the README so components and patterns are described. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
approved these changes
Jan 26, 2017
renstah
reviewed
Jan 26, 2017
|
|
||
| ## Why? | ||
|
|
||
| We are sure that we are solving the same UX/UI problems every day. Sometimes these problems relate to basic patterns | ||
| and other times they are more complex. Therefor we believe in a library like this to describe these problems | ||
| so we are able to recognize them and choose for an existing implementation before writing our own. | ||
| and other times they are more complex. Therefor we believe in a library, like this, to describe these problems so we |
There was a problem hiding this comment.
Double comma's in this sentence reads a bit strange. I think the comma after libray is obsolete,
| on the [template] in this repository. You can create a PR with the new file in the | ||
| proposed directory. The file **MUST** be named with the name of your pattern. | ||
| To create a new proposal fork this repository and create a new markdown file based on the [template] in this | ||
| repository. You can create a PR with the new file in the proposed directory. The file **MUST** be named with the name |
There was a problem hiding this comment.
I think it is better to rename PR to Pull Request, not all the users that are going to cooperate are technical users or github users.
|
|
||
| After your PR was accepted the proposed pattern will be moved to the accepted | ||
| directory by one of the owners. | ||
| After your PR was accepted the proposed pattern will be moved to the accepted directory by one of the owners. |
There was a problem hiding this comment.
'was' needs to be 'is' and after accepted there needs to be a comma.
|
Thanks @renstah Updated the README with your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the README so that the difference between components and patterns is more clear.