Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Colors #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Core Colors #7

wants to merge 1 commit into from

Conversation

renstah
Copy link
Contributor

@renstah renstah commented Jan 26, 2017

No description provided.

@renstah renstah requested a review from waltertamboer January 26, 2017 22:42
waltertamboer
waltertamboer suggested changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@waltertamboer waltertamboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we depend on colors? Colors are application specific and we tried to make the patterns as abstract as possible (position, size).

@waltertamboer waltertamboer changed the title new proposal for a core component Color Component Jan 27, 2017
@waltertamboer waltertamboer changed the title Color Component Core Colors Jan 27, 2017
@renstah
Copy link
Contributor Author

renstah commented Jan 27, 2017 •
edited
Loading

The colors should be configurable. Every project have its own colors yes, so it should be easy for the pattern / component developers to implement the default color palette that is configured by the user of the library. Trough this pattern we can ensure the danger label is in the same color range as the danger alert or the success button color is in the same range as a success panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltertamboer waltertamboer waltertamboer requested changes

Assignees
No one assigned
Labels
draft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renstah @waltertamboer