Add support for custom CA certs #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kralicky
changed the title
kenjenkins
approved these changes
Apr 30, 2024
verify.go
Outdated
| if len(cfg.extraCACerts) > 0 { | ||
| pool, err := x509.SystemCertPool() | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Should we log.Fatal() here, for consistency with the other error handling logic below?
kralicky
added
enhancement
This adds a new environment variable 'EXTRA_CA_CERTS' which can contain a comma-separated list of file paths to CA certs. These certs will be used in addition to the system defaults.
kralicky
force-pushed
the
kralicky/custom-ca-certs
branch
from
f0fc24a to
aa4d460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new environment variable 'EXTRA_CA_CERTS' which can contain a comma-separated list of file paths to CA certs. These certs will be used in addition to the system defaults.