Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product card as well as img #371

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

Varsani2520
Copy link
Contributor

i solve the card size issue as well as imagesnot displaying issue

Fixes # (issue)
#369

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

Screenshots and Videos:

image

Checklist:

Give a X on, which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 4:12am

Copy link
Owner

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Varsani2520! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Varsani2520
Copy link
Contributor Author

i added img in supabase and remove dummy images as well as solve the size

@pooranjoyb review it

src/pages/Shop/Shop.tsx Outdated Show resolved Hide resolved
@pooranjoyb pooranjoyb added ui Improvements of User Interface level1 Issue with difficulity level 1 gssoc Girlscript Summer of Code 2024 labels Jul 27, 2024
@Varsani2520
Copy link
Contributor Author

@pooranjoyb now check it

@pooranjoyb
Copy link
Owner

Also do #373 and #374 in this same PR only. @Varsani2520

@Varsani2520
Copy link
Contributor Author

@pooranjoyb ,first this PR merged so i can work on #373 and #374

@pooranjoyb
Copy link
Owner

pooranjoyb commented Jul 27, 2024

@pooranjoyb ,first this PR merged so i can work on #373 and #374

yeh do those changes in this same PR only. Shouldn't be an issue.

@Varsani2520
Copy link
Contributor Author

@pooranjoyb ,i fixed #374
image

@pooranjoyb pooranjoyb merged commit ced1d2f into pooranjoyb:dev Jul 29, 2024
2 checks passed
@pooranjoyb pooranjoyb added level2 Issues with difficulity level 2 utility Some Funtionality or Some Utility and removed level1 Issue with difficulity level 1 labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level2 Issues with difficulity level 2 ui Improvements of User Interface utility Some Funtionality or Some Utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants