feat: Gesture configuration in shortcuts config #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanabx
force-pushed
the
gestures
branch
7 times, most recently
from
23542a8 to
93f7fb1
Compare
|
Rebased on latest master. Can I get a review soon if there's any free time? |
mmstick
reviewed
Mar 19, 2025
mmstick
reviewed
Mar 19, 2025
config/src/shortcuts/gesture.rs
Outdated
|
|
||
| impl Gesture { | ||
| /// Creates a new gesture from a number of fingers and a direction | ||
| pub fn new(fingers: impl Into<u32>, direction: impl Into<Direction>) -> Gesture { |
There was a problem hiding this comment.
I don't think there's a need for generic input parameters here. Use of constant types will prevent unnecessary monomorphization and inlining.
There was a problem hiding this comment.
Done in v3. Also made fingers an enum, to limit the fingers that can be used as gestures. Unsure if this is something we want or not
mmstick
reviewed
Mar 19, 2025
mmstick
reviewed
Mar 19, 2025
mmstick
reviewed
Mar 19, 2025
mmstick
reviewed
Mar 19, 2025
config/src/shortcuts/mod.rs
Outdated
| let mut gestures = context | ||
| .get::<Gestures>("default_gestures") | ||
| .unwrap_or_else(|why| { | ||
| tracing::error!("shortcuts defaults config error: {why:?}"); |
There was a problem hiding this comment.
Use if why.is_err() {} to check if the error is worth logging. Otherwise this will spam the logs if the config is not in use.
There was a problem hiding this comment.
Done in v2.
I assume I shouldn't do the same for the custom gestures?
mmstick
reviewed
Mar 19, 2025
ryanabx
force-pushed
the
gestures
branch
3 times, most recently
from
34c9e55 to
fdf1f1b
Compare
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
mmstick
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in.
The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type.
This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396)
Let me know what needs to be changed!