[RFC] Code smell #580
Draft
[RFC] Code smell #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
force-pushed
the
chore/fix-code-smell
branch
from
8a1234f
to
1614cb7
Compare
acolombier
force-pushed
the
chore/fix-code-smell
branch
from
1614cb7
to
050c882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I recently worked on that project, I realised there was a lot of warning from
clippyabout various code smell.I have fixed most of those displayed when running the
clippycommand, and I wanted to see what the team though of that. If you like it, I'd be happy to push that further and add a quality gate as well so we can help maintaining a good code quality going forward.Happy to close if you think this is overkill and that
clippywarning could be ignored.