-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 linux #247
Add arm64 linux #247
Conversation
40bf778
to
0fcc8e4
Compare
0fcc8e4
to
bcd71af
Compare
It looks like we have to add it to the org for us to use the Arm64 runners: https://github.com/actions/partner-runner-images?tab=readme-ov-file#available-images |
The |
Cross-compiling is easy with Rust, though the C library dependencies are a hassle. If pkg-config handles those fine though, it would work with an arm64 sysroot that has the necessary packages. |
We could build it with another CI to not need to be signed and just provide the hash I believe right? |
Yeah, that's also a possibility, if there are good alternatives. The |
@ids1024 sorry I meant to just put the arm64 AppImage in the Github release and link to it from the site since it isn't signed anyway. The CI is only really for making a release automatic. |
You mean building locally on an ARM64 system and add it to the release manually? Yeah, that should work too. |
I built the latest 1.3.12 release on an Astra yesterday which I can send over. If we want to add building that as a checkbox that could work and I would just remove my changes to the ci.yml file so this PR should pass. |
Yeah, merging any changes to the appimage build script and leaving CI unchanged for now would be good here. It may not be that hard to set up a cross-compile build. I think I almost have that working after building an arm64 focal sysroot using debootstrap and setting some |
I've removed it for now and we can add it back later. Depending on the Github pricing we may want to look at this: https://www.blacksmith.sh/blog/building-multi-platform-docker-images-for-arm64-in-github-actions |
It looks like we may be able to use the CI soon! |
231598e
to
cbbf190
Compare
Well after running it again it works now! |
I rebased on master with the Windows fix and all the CI are passing now! |
The Otherwise, the
Looks like you did a cherry-pick instead of a rebase? It should be rebased, and squashed into one or two commits. But doing a squash merge may amount to the same thing. |
I don't think the Yea looks like GH's default is to "Squash and merge" which should fix it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. (As long as it's merged with a squash merge.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only touches build scripts and CI seems happy, so I think that's sufficient.
This builds if you run the
build.py
file with the ARCH that matches your system enabled:This also updates the
linuxdeploy-plugin-gtk.sh
to match upstream as that builds for me locally using./build.py --release
.