Desktop entries update #219

wiiznokes · 2024-06-08T20:29:50Z

run cargo clippy and fmt on the all project
update edition
update fde (depend on Fix applist freedesktop-desktop-entry#20)
update the desktop_entries plugin to take advantage of the matching function of fde

I plan to start playing with the score now, for modifying to order of the result. I don't include it in this PR to keep things separate, but since the new matching function will match more things, currently, the search result are not as good as previously. see #217

jacobgkau

I noticed a search behavior change that seems odd. Searching for "test", I used to get the Blackmagic RAW Speed Test app I have installed on this system as the first result:

On this branch, it doesn't show up as a result at all when searching for that string:

Searching for something more specific does yield the result, so it's still being detected as an entry by the launcher:

Any idea why this update would cause fuzzy matches to have priority over an exact match? Not matching an exact term anymore seems like a regression.

wiiznokes · 2024-06-26T19:35:00Z

Yes, I think i understand why this is the case. The old impl use

let append = search_interest.starts_with(&*query)
                    || query
                        .split_ascii_whitespace()
                        .any(|query| search_interest.contains(&*query))
                    || strsim::jaro_winkler(&*query, &*search_interest) > 0.6;

for matching while the new only use strsim::jaro_winkler(&*query, &*search_interest) (in fde).

Having both

search_interest.starts_with(&*query)
                    || query
                        .split_ascii_whitespace()
                        .any(|query| search_interest.contains(&*query))

seems redundant. I will add the contains condition and update you

jacobgkau · 2024-06-28T19:01:48Z

No rush, but just to make sure this isn't waiting on us again, I assume something will need to be done in this PR to bring pop-os/freedesktop-desktop-entry#23 in? Not sure if the freedesktop-desktop-entry version needs to be bumped, but we at least need a new git commit hash to trigger a rebuild.

wiiznokes · 2024-06-28T19:32:41Z

I assume fde needs a new version

jacobgkau · 2024-07-03T09:41:44Z

@mmstick Can you make a crate release including pop-os/freedesktop-desktop-entry#23 so we can bump the version used in this PR to fix that regression?

mmstick · 2024-07-03T14:51:52Z

Sure

mmstick · 2024-07-03T15:23:43Z

Released as 0.6.2

wiiznokes · 2024-07-08T19:59:04Z

@jacobgkau Sorry for the ping, i just making sure you aware that this pr is now ready for review again :)

jacobgkau · 2024-07-08T20:45:04Z

@wiiznokes I saw it this morning. There's some other work we're busy with at the moment, but I will review this again this week, hopefully within the next day or so.

jacobgkau

On 4f281f7, the Blackmagic RAW Speed Test app now shows up when searching test. However, searching for settings does not return the Settings app (a.k.a. GNOME Control Center) as a result. On this machine, it currently shows up as the second option when searching for that term on the released/master branch.

jacobgkau

The test and settings queries are both working as expected now.

Standard regression testing failed. GNOME Settings panels are not showing up in search anymore with this update. This can be tested with e.g. appearance for the Appearance panel or wifi for the Wi-Fi panel.

wiiznokes · 2024-07-10T20:45:28Z

I suppose this is a popos only thing? Would you be able to provide an example of .desktop file that don't work? I'm on Fedora

mmstick · 2024-07-10T20:59:35Z

gnome-control-center desktop entries in the GNOME session should be searchable.

jacobgkau · 2024-07-10T21:20:01Z

Would you be able to provide an example of .desktop file that don't work?

Here's one, for the Appearance page:

[Desktop Entry]
Name=Appearance
Comment=Set light or dark theme
Exec=gnome-control-center desktop-appearance
# FIXME
# Translators: Do NOT translate or transliterate this text (this is an icon file name)!
Icon=preferences-pop-desktop-appearance
Terminal=false
Type=Application
NoDisplay=true
StartupNotify=true
Categories=GNOME;GTK;Settings;DesktopSettings;X-GNOME-Settings-Panel;X-POP-DesktopSettings;
OnlyShowIn=GNOME;Unity;
# Translators: Search terms to find the Privacy panel. Do NOT translate or localize the semicolons! The list MUST also end with a semicolon!
Keywords=
X-Ubuntu-Gettext-Domain=gnome-control-center-2.0

It's installed to /usr/share/applications/gnome-desktop-appearance-panel.desktop in Pop!_OS.

wiiznokes · 2024-07-10T23:08:25Z

I see. Last commits should solve this issue.

The current behavior seems odd to me. The launcher will search in desktop entries that set NoDisplay=true, which is technically fine, but will discard any entry that set NoDisplay=true and don't have an OnlyShowIn field. This is the case for example for applets entries.

I'm not sure if applets should use the desktop enty spec here. It could potentially impact other DEs if i understand correctly. cc @mmstick

mmstick · 2024-07-10T23:13:02Z

The previous logic was based on the session. If you are in the GNOME session, then desktop entries which use OnlyShowIn=GNOME will appear regardless of NoDisplay=true.

wiiznokes · 2024-07-10T23:17:10Z

Yes, i guess this is fine, even if the launcher could miss some useful entry of normal app (i don't have an example but an app not specific to a DE could use NoDisplay=true.

This means another launcher could choose to display this kind of entries, and then, all cosmic applets shows up.

mmstick · 2024-07-10T23:18:48Z

Yeah, we similarly want cosmic settings pages to appear in the launcher, but not in the app library.

wiiznokes · 2024-07-10T23:23:56Z

Yes, but my point was related to cosmic applets. AFAIU, cosmic applets are not meant to be presented in launchers or app library

wiiznokes · 2024-07-10T23:25:53Z

And the only things that prevent them to being displayed are NoDisplay=true and no OnlyShowIn field, which is not in the spec, if i'm not mistaken

mmstick · 2024-07-10T23:33:30Z

It's what GNOME is doing, so we're working with behaviors that are already being relied upon.

wiiznokes · 2024-07-10T23:40:24Z

I see. The last 2 commits implements this behavior

jacobgkau

Found another issue on 6ec06ef during standard regression testing. Searching for extensions should only return one entry. Before:

With this branch, there are two results for that app:

This .desktop file comes from /usr/share/applications/org.gnome.Extensions.desktop:

[Desktop Entry]
Type=Application
Name=Extensions
# Translators: Do NOT translate or transliterate this text (this is an icon file name)!
Icon=org.gnome.Extensions
Comment=Configure GNOME Shell Extensions
Exec=/usr/bin/gnome-extensions-app --gapplication-service
DBusActivatable=true
Categories=GNOME;GTK;Utility;
OnlyShowIn=GNOME;
X-Ubuntu-Gettext-Domain=gnome-shell

wiiznokes · 2024-07-11T22:37:09Z

Damn, this will never end 😭

I don't really know why there is 2 extensions now. I'm using the same logic to deduplicate entries, e.i, only with the appid. I made a test on my machine and it seems to deduplicate as intented. I think it would help if you can provide the other org.gnome.Extensions.desktop

Thanks

jacobgkau · 2024-07-11T23:08:54Z

Aha. I found this issue from just before this item was added to our QA checklist: pop-os/shell#293

In addition to the org.gnome.Extensions.desktop that I posted before, there is also an org.gnome.Shell.Extensions.desktop installed to the same location:

[Desktop Entry]
Type=Application
# Keep in sync with subprojects/extensions-app
Name=Extensions
# Translators: Do NOT translate or transliterate this text (this is an icon file name)!
Icon=org.gnome.Shell.Extensions
# Never launch this, just provide name+icon to portal dialog
Exec=false
OnlyShowIn=GNOME;
NoDisplay=true
X-Ubuntu-Gettext-Domain=gnome-shell

I do want to point out that if existing behaviors are breaking the spec, we could probably consider following the spec if we fix those behaviors in their respective other components (i.e. patch the .desktop files in gnome-shell/gnome-control-center/etc). We just can't ship the update when it would break user-facing behaviors on the checklist.

As for why this duplicate wasn't showing up before, I think it's because the exec line is set to false. If I change the exec line for e.g. LibreOffice Writer's .desktop file to false, it shows with this branch and doesn't show on master. So that's the regression we're looking at now.

wiiznokes · 2024-07-12T00:26:52Z

As for why this duplicate wasn't showing up before, I think it's because the exec line is set to false.

Yep, that must be it. I don't think this is in the spec but that's not surprising coming from Gnome

wiiznokes · 2024-07-12T01:25:30Z

Should be hopefully good now

jacobgkau

The test and settings queries are still working as expected.

Standard regression testing passed:

wiiznokes added 9 commits June 5, 2024 23:37

add-journald-log

864317f

apply cargo fix and fmt

7dc36cf

change edition

c2af1bc

upgrade log function

9007374

begin refractor

19f8dd7

init

f680f24

update fde

d904f2b

add workspace deps

6dc3da0

fde 0.6.1

eab50be

mmstick previously approved these changes Jun 10, 2024

View reviewed changes

mmstick requested a review from a team June 10, 2024 14:20

wiiznokes mentioned this pull request Jun 11, 2024

Bookmark/history firefox #221

Closed

2 tasks

jacobgkau requested changes Jun 26, 2024

View reviewed changes

wiiznokes mentioned this pull request Jun 26, 2024

feat: always match exact match pop-os/freedesktop-desktop-entry#23

Merged

wiiznokes mentioned this pull request Jul 3, 2024

Feat/alt tab cycle #225

Closed

update fde

4f281f7

wiiznokes dismissed mmstick’s stale review via 4f281f7 July 3, 2024 16:00

wiiznokes requested a review from jacobgkau July 3, 2024 16:01

mmstick previously approved these changes Jul 3, 2024

View reviewed changes

jacobgkau requested changes Jul 9, 2024

View reviewed changes

call to_ascii_lowercase for matching desktop names

dad5e3d

wiiznokes dismissed mmstick’s stale review via dad5e3d July 10, 2024 14:27

mmstick previously approved these changes Jul 10, 2024

View reviewed changes

jacobgkau requested changes Jul 10, 2024

View reviewed changes

remove no_display constaint

9a755bc

wiiznokes dismissed mmstick’s stale review via 9a755bc July 10, 2024 22:53

Update mod.rs

6ec06ef

wiiznokes requested a review from jacobgkau July 10, 2024 23:40

mmstick previously approved these changes Jul 10, 2024

View reviewed changes

jacobgkau requested changes Jul 11, 2024

View reviewed changes

add exec and name constraint

ea2137e

wiiznokes dismissed mmstick’s stale review via ea2137e July 12, 2024 01:25

mmstick approved these changes Jul 12, 2024

View reviewed changes

jacobgkau approved these changes Jul 12, 2024

View reviewed changes

mmstick merged commit 1725320 into pop-os:master Jul 12, 2024
8 checks passed

mmstick mentioned this pull request Jul 12, 2024

Search results are different in COSMIC than GNOME. COSMIC results are incorrect. pop-os/cosmic-launcher#145

Closed

wiiznokes deleted the desktop_entries_update branch December 11, 2024 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Desktop entries update #219

Desktop entries update #219

wiiznokes commented Jun 8, 2024 •

edited

Loading

jacobgkau left a comment

wiiznokes commented Jun 26, 2024

jacobgkau commented Jun 28, 2024

wiiznokes commented Jun 28, 2024

jacobgkau commented Jul 3, 2024

mmstick commented Jul 3, 2024

mmstick commented Jul 3, 2024

wiiznokes commented Jul 8, 2024

jacobgkau commented Jul 8, 2024

jacobgkau left a comment

jacobgkau left a comment

wiiznokes commented Jul 10, 2024

mmstick commented Jul 10, 2024

jacobgkau commented Jul 10, 2024 •

edited

Loading

wiiznokes commented Jul 10, 2024

mmstick commented Jul 10, 2024

wiiznokes commented Jul 10, 2024 •

edited

Loading

mmstick commented Jul 10, 2024

wiiznokes commented Jul 10, 2024

wiiznokes commented Jul 10, 2024

mmstick commented Jul 10, 2024

wiiznokes commented Jul 10, 2024

jacobgkau left a comment

wiiznokes commented Jul 11, 2024

jacobgkau commented Jul 11, 2024

wiiznokes commented Jul 12, 2024

wiiznokes commented Jul 12, 2024

jacobgkau left a comment

Desktop entries update #219

Desktop entries update #219

Conversation

wiiznokes commented Jun 8, 2024 • edited Loading

jacobgkau left a comment

Choose a reason for hiding this comment

wiiznokes commented Jun 26, 2024

jacobgkau commented Jun 28, 2024

wiiznokes commented Jun 28, 2024

jacobgkau commented Jul 3, 2024

mmstick commented Jul 3, 2024

mmstick commented Jul 3, 2024

wiiznokes commented Jul 8, 2024

jacobgkau commented Jul 8, 2024

jacobgkau left a comment

Choose a reason for hiding this comment

jacobgkau left a comment

Choose a reason for hiding this comment

wiiznokes commented Jul 10, 2024

mmstick commented Jul 10, 2024

jacobgkau commented Jul 10, 2024 • edited Loading

wiiznokes commented Jul 10, 2024

mmstick commented Jul 10, 2024

wiiznokes commented Jul 10, 2024 • edited Loading

mmstick commented Jul 10, 2024

wiiznokes commented Jul 10, 2024

wiiznokes commented Jul 10, 2024

mmstick commented Jul 10, 2024

wiiznokes commented Jul 10, 2024

jacobgkau left a comment

Choose a reason for hiding this comment

wiiznokes commented Jul 11, 2024

jacobgkau commented Jul 11, 2024

wiiznokes commented Jul 12, 2024

wiiznokes commented Jul 12, 2024

jacobgkau left a comment

Choose a reason for hiding this comment

wiiznokes commented Jun 8, 2024 •

edited

Loading

jacobgkau commented Jul 10, 2024 •

edited

Loading

wiiznokes commented Jul 10, 2024 •

edited

Loading