feat: optionally use POP_LAUNCHER_LIB_DIR env variable

[ryanabx]

This environment variable describes where the pop-launcher distribution path exists. The default for this is /usr/lib/pop-launcher; however, some distributions would like to use /usr/libexec/pop-launcher instead.

[ryanabx]

Note that we will also need to update cosmic-launcher's Cargo.lock to account for the changes here, I think

[mmstick]

Shouldn't be necessary since it (cosmic-launcher) communicates to the pop-launcher sub-process via IPC over stdin/stdout.

[ryanabx]

Shouldn't be necessary since it (cosmic-launcher) communicates to the pop-launcher sub-process via IPC over stdin/stdout.

Oh I didn't know, thanks!

[jacobgkau]

This moves the system-wide pop-launcher/{plugins,scripts} directories from /usr/lib/ to /usr/libexec/. There's no change in behavior.

Regression testing passed:

Launcher

• All windows on all workspaces appear on launch
• Choosing an app on another workspace moves workspaces and focus to that app
• Launching an application works
• Typing text and then removing it will re-show those windows
• Search works for applications and windows
• Search works for GNOME settings panels
• Search for "Extensions". There should be only one entry.
• The overlay hint correctly highlights the selected window
• Open windows are sorted above applications (e.g. "firefox")
• t: executes a command in a terminal
• : executes a command in sh
• = calculates an equation
• Search results are as expected:
  • cal returns Calendar and Calculator before Color
  • pops returns Popsicle first
  • shop returns the Pop!_Shop first

[jackpot51]

I believe both Arch and NixOS have issues with /usr/libexec. The best thing to do is make it configurable.

[ryanabx]

@jackpot51 how's this?

[Conan-Kudo]

/usr/libexec should be the default since that is the recommended place for the majority of distributions (Fedora, openSUSE, Debian/Ubuntu, etc.) and distributions who want an alternative location can set it otherwise.

[wiiznokes]

I wonder how the POP_LAUNCHER_LIB_DIR even works since it is not exported in a build.rs file.

Except that, i have some suggestion/question

• why all the paths have been duplicated in the code ?
• could we change option_env! to env!, and declare the POP_LAUNCHER_LIB_DIR variable in the justfile. This will make things a bit less magic, and easier for packaging and development i think, because we will just need to call change lib-path in the Makefile.