Skip to content

Commit

Permalink
improv: Display "Flashing Competed with Errors" on error
Browse files Browse the repository at this point in the history
Partially addresses #120. The
green check mark icon also seems a bit out of place in this case; not
sure what would be best.
  • Loading branch information
ids1024 committed May 19, 2021
1 parent c08feaa commit 874fc8c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions gtk/src/app/signals/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,8 @@ impl App {
description.set_text(&desc);
list.hide();
} else {
ui.content.summary_view.view.topic.set_text(&fl!("flashing-completed-with-errors"));

let mut desc = fl!(
"partial-flash",
number = {ntasks - errors.len()},
Expand Down
3 changes: 2 additions & 1 deletion i18n/en/popsicle_gtk.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ flash-view-title = Flashing Devices
# Summary View
flashing-completed = Flashing Completed
flashing-completed-with-errors = Flashing Completed with Errors
flash-again = Flash Again
# Error View
Expand All @@ -45,4 +46,4 @@ win-isos-not-supported = Windows ISOs are not currently supported
# Errors
iso-open-failed = Failed to open ISO
no-value-found = no value found
no-value-found = no value found

0 comments on commit 874fc8c

Please sign in to comment.