Disable suspend on idle for Digital outputs by default #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cae0c2c.
mmstick
approved these changes
Jul 13, 2022
|
You could propose the PR to the upstream wireplumber project. They'd be able to give better advice on the change. |
Will give it a shot as well, thanks. |
mmstick
pushed a commit
that referenced
this pull request
Jul 17, 2024
not all functions in glib returns a value for the used log fields
in this case a 'g_return_val_if_fail(..) will only set 4 fields an
set the other field to NULL which leads to a segfault
Jul 22 13:41:37 Cynap-Pro-01121508 systemd-coredump[7247]: Process 496 (wireplumber) of user 4242 dumped core.
Stack trace of thread 496:
#0 0x00007f6b2ce58e99 __strlen_avx2 (libc.so.6 + 0x150e99)
#1 0x00007f6b2cf3ebe5 g_log_writer_journald (libglib-2.0.so.0 + 0x5fbe5)
#2 0x00007f6b2d0a9316 wp_log_fields_write_to_journal (libwireplumber-0.5.so.0 + 0x2b316)
#3 0x00007f6b2d0a96f5 wp_log_writer_default (libwireplumber-0.5.so.0 + 0x2b6f5)
#4 0x00007f6b2cf3cf3e g_log_structured_array (libglib-2.0.so.0 + 0x5df3e)
#5 0x00007f6b2cf3d0ae g_log_structured_array (libglib-2.0.so.0 + 0x5e0ae)
#6 0x00007f6b2cf3d4b7 g_logv (libglib-2.0.so.0 + 0x5e4b7)
#7 0x00007f6b2cf3d7ef g_log (libglib-2.0.so.0 + 0x5e7ef)
#8 0x00007f6b29efafef get_node_by_id (libwireplumber-module-cb-ipc.so + 0x24fef)
#9 0x00007f6b29efb032 wp_cb_ipc_get_app_properties (libwireplumber-module-cb-ipc.so + 0x25032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an annoying problem with digital outputs that I assume should be common with most digital audio devices.
When the device receives an audio signal again after suspending, it takes a couple of seconds to start up, causing the user to miss the audio that played back during that time.
E.g., https://unix.stackexchange.com/questions/676846/how-do-i-disable-audio-sink-suspend-on-idle-using-wireplumber-in-fedora-35-so-th
I'm not 100% sure if matching "Digital" in the node description is the best approach.
Although it did work for me as all my digital output nodes had that in the description, I'm not sure that would apply for all devices people might be using.
However it seemed better than simply applying the property to all audio outputs as I don't know the side effects that might cause.
Clearly I'm no expert so I'm sorry if I did anything wrong and any input is appreciated.
Thanks