Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify add_dfe docs (closes #1580) #1663

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

petrelharp
Copy link
Contributor

Also fixed the code display:
Screenshot from 2025-01-20 07-59-32

tldr; is that stdpopsim, like msprime/tskit, uses [a,b); while SLiM uses [a,b].

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (0ab99e0) to head (ce075b0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         136      136           
  Lines        4653     4653           
  Branches      468      468           
=======================================
  Hits         4646     4646           
  Misses          3        3           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mufernando mufernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important clarification! LGTM.

@petrelharp petrelharp merged commit 8aaeecd into popsim-consortium:main Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants