Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Import old recipe: Create users ldap #72

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Import old recipe: Create users ldap #72

merged 13 commits into from
Jun 21, 2024

Conversation

jonkeane
Copy link
Collaborator

@jonkeane jonkeane commented Jun 7, 2024

resolves #43

wydsith
wydsith reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@wydsith wydsith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits from me :)

user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
tdstein
tdstein reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some build errors.

@jonkeane
Copy link
Collaborator Author

Looks like there are some build errors.

Those are there on main too. We should fix them, but I don't think it's this PR that's the issue

https://github.com/posit-dev/connect-cookbook/actions/runs/9388376592/job/25853479030

@nealrichardson
Copy link
Contributor

Looks like there are some build errors.

Those are there on main too. We should fix them, but I don't think it's this PR that's the issue

https://github.com/posit-dev/connect-cookbook/actions/runs/9388376592/job/25853479030

We should disable the site build until we figure it out.

nealrichardson
nealrichardson approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me. Only thing that occurs to me that might be useful to note is what happens if there are 0 matches to the prefix, or >1 (especially for the R function that does it all).

user/create-user-ldap/index.qmd Show resolved Hide resolved
toph-allen
toph-allen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor copy edits for clarity. Other than that, looks good (except for CI — which is also an error I see when running locally without restoring the renv environment.)

user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
user/create-user-ldap/index.qmd Outdated Show resolved Hide resolved
@jonkeane jonkeane mentioned this pull request Jun 21, 2024
Merged
jonkeane and others added 12 commits June 21, 2024 10:44
@jonkeane @tdstein
create users ldap
d4417f3
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
bfd5944 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
3e0b6eb 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
de76600 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
c24de00 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
6f5dd4c 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
f2ea932 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
17c58a4 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
2cf798b 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @wydsith @tdstein
Update user/create-user-ldap/index.qmd
1d3ecf1 
Co-authored-by: annikakrilov <[email protected]>
@jonkeane @tdstein
Update user/create-user-ldap/index.qmd
d4e488a 
Co-authored-by: Taylor Steinberg <[email protected]>
@jonkeane @tdstein
PR comments
4c7b555
@jonkeane jonkeane merged commit 4532089 into main Jun 21, 2024
1 check passed
@jonkeane jonkeane deleted the create-ldap-user branch June 21, 2024 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wydsith wydsith wydsith left review comments

@kmasiello kmasiello kmasiello approved these changes

@tdstein tdstein tdstein approved these changes

@toph-allen toph-allen toph-allen approved these changes

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import existing recipe: Create a Posit Connect user from LDAP or OAuth2
6 participants
@jonkeane @nealrichardson @toph-allen @tdstein @kmasiello @wydsith