-
Notifications
You must be signed in to change notification settings - Fork 101
python upstream merge v2025.6.1
#7811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
E2E Tests 🚀 |
Signed-off-by: Isabel Zimmerman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about 11.5k of the 12k changes are the package-lock.json
apart from that, the main bits that are sort of interesting:
- adding in pyrefly compatability testing
- moving min version 3.8 -> 3.9
- some new testing fixtures, not sure if we would want to use
MockExtensions
at all for checking cross-extension compatability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've never seen anything quite like this in a PR, neat!
@@ -317,7 +317,7 @@ def write_output( | |||
if __name__ == "__main__": | |||
main( | |||
requirement="ipykernel", | |||
python_versions=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"], | |||
python_versions=["3.9", "3.10", "3.11", "3.12", "3.13"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we good to drop 3.8 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so! Missed one in #6856 I guess
@@ -310,7 +314,14 @@ export class PythonSettings implements IPythonSettings { | |||
userLS === 'Microsoft' || | |||
!Object.values(LanguageServerType).includes(userLS as LanguageServerType) | |||
) { | |||
this.languageServer = this.defaultLS?.defaultLSType ?? LanguageServerType.None; | |||
if ( | |||
this.extensions.getExtension(PYREFLY_EXTENSION_ID) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pyrefly starting to be added into tests/extension
|
||
// --- Start Positron --- | ||
// We are using Jedi as the default language server, and it is not configurable. | ||
suite.skip('pyrefly languageServer settings', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're skipping pyrefly tests for now, since the LSP is not configurable in Positron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@@ -317,7 +317,7 @@ def write_output( | |||
if __name__ == "__main__": | |||
main( | |||
requirement="ipykernel", | |||
python_versions=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"], | |||
python_versions=["3.9", "3.10", "3.11", "3.12", "3.13"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so! Missed one in #6856 I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be interesting to try out this coverage stuff on our fork sometime!
@@ -94,6 +94,9 @@ export class JediLanguageServerAnalysisOptions extends LanguageServerAnalysisOpt | |||
maxSymbols: 0, | |||
}, | |||
}, | |||
semantic_tokens: { | |||
enable: true, | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, cool, hopefully pappasam/jedi-language-server#340 is fixed soon
from
v2025.4.0
->v2025.6.1
Nothing too exciting here beyond loads of
package-lock.json
changes (all but ~700 changed lines 😩). Somepyrefly
testing, updates to theunittest
adapter, etc. I'll add comments to the interesting bits!Release Notes
New Features
Bug Fixes
vscode-python
v2026.6.1
QA Notes
Should pass tests!